Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: posix-standard flags #354

Closed
ghostsquad opened this issue Aug 20, 2020 · 3 comments
Closed

request: posix-standard flags #354

ghostsquad opened this issue Aug 20, 2020 · 3 comments
Labels
kind/feature Something new should be added

Comments

@ghostsquad
Copy link

I noticed that tk accepts flags such as:

--extCode

I can't find explicitly if it's mentioned not to use capital letters in long option names, but this was definitely surprising when I found it, and doesn't follow many other conventions in other tools. I think this should instead be:

--ext-code
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.87. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@sbarzowski
Copy link

I think that if you make the change, you should keep the old variant as well (maybe undocumented), to avoid breaking existing scripts. (Just my 2 cents).

@sh0rez
Copy link
Member

sh0rez commented Aug 21, 2020

Oh, that change has already happened in #340 11 days ago. We decided these flags weren't widely used enough to care about compatibility here, so just went ahead converted to match what the jsonnet binaries do.

Closing as basically solved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Something new should be added
Projects
None yet
Development

No branches or pull requests

3 participants