Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default RED Metric names from otelcol spanmetricsconnector are chainging in v0.109.0 #1073

Open
frzifus opened this issue Oct 28, 2024 · 4 comments

Comments

@frzifus
Copy link
Collaborator

frzifus commented Oct 28, 2024

RED Metrics generated by the spanmetricsconnector will be prefixed by default when using an OpenTelemetry Collector v0.109.0 or higher.

We currently configure jaeger-query to fallback to the old behaviour without any prefix. We might want to support an option to use both variants.

See:

@pavolloffay
Copy link
Collaborator

I wonder why @iblancasa didn't bring this to attention :)

@iblancasa
Copy link
Collaborator

I wonder why @iblancasa didn't bring this to attention :)

I mentioned the change in my internal status report and during one of our 1on1s.

https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.109.0

https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/connector/spanmetricsconnector#configurations there is namespace configuration option, does it work if we set it to an empty string?

There is a feature flag. Doesn't it help?

@pavolloffay
Copy link
Collaborator

The FF does not help. IIRC we would need make code changes in the operator to enable it.

I think we have 2 options:

  • set the namespace to empty in the collector config. @frzifus could you please test it?
  • make the breaking change in 3.4 to use the default namespace and allow overriding the namespace in tempo CR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants