Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Pod Disruption Budget for Ingesters in production jsonnet #1571

Closed
zalegrala opened this issue Jul 13, 2022 · 0 comments · Fixed by #1691
Closed

Configure Pod Disruption Budget for Ingesters in production jsonnet #1571

zalegrala opened this issue Jul 13, 2022 · 0 comments · Fixed by #1691
Milestone

Comments

@zalegrala
Copy link
Contributor

zalegrala commented Jul 13, 2022

We currently don't have a pod disruption budged set on the Ingesters in our microservices jsonnet, and we might want to consider adding one. This should signal to Kubernetes that we can only tolerate a single ingester down at a time.

Loki has something similar that we might want to model. https://github.com/grafana/loki/blob/cac0091dbea1660d1ebc855e621a6544e2eb3ea0/production/ksonnet/loki/ingester.libsonnet

ingester_pdb:
    podDisruptionBudget.new() +
    podDisruptionBudget.mixin.metadata.withName('loki-ingester-pdb') +
    podDisruptionBudget.mixin.metadata.withLabels({ name: 'loki-ingester-pdb' }) +
    podDisruptionBudget.mixin.spec.selector.withMatchLabels({ name: name }) +
    podDisruptionBudget.mixin.spec.withMaxUnavailable(0),

https://kubernetes.io/docs/reference/using-api/deprecation-guide/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants