Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to cut an active block based on total bytes #474

Closed
joe-elliott opened this issue Jan 25, 2021 · 0 comments · Fixed by #477
Closed

Add support to cut an active block based on total bytes #474

joe-elliott opened this issue Jan 25, 2021 · 0 comments · Fixed by #477

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently Tempo allows for cutting the active block based on time or total traces. However trace size can vary wildly. This should allow for cutting the active block by total current bytes.

https://github.com/grafana/tempo/blob/master/modules/ingester/config.go#L20-L21

Describe the solution you'd like
Add a config option (max_block_bytes ?) that cuts a block when the threshold is reached. I think we should remove traces_per_block in favor of this setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant