Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Arguments must not be quoted #70

Closed
ghost opened this issue Sep 23, 2019 · 5 comments
Closed

Error: Arguments must not be quoted #70

ghost opened this issue Sep 23, 2019 · 5 comments
Assignees

Comments

@ghost
Copy link

ghost commented Sep 23, 2019

This issue was originally opened by @ashishsarkar as hashicorp/terraform#22881. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version

Terraform v0.12.7

Terraform Configuration Files

resource "grafana_alert_notification" "email_notification" {
  name = "email_notification"
  type = "email"
  is_default = false

  settings = {
    addresses = "xyz@mail.com;abc@mail.com"
    uploadImage = "false"
  }
}

Debug Output

$ terraform plan
Error: Argument names must not be quoted...

Crash Output

Expected Behavior

Actual Behavior

Steps to Reproduce

provider "grafana" {
url = "http://:3000"
auth = "admin:admin"
}
resource "grafana_alert_notification" "email_someteam" {
name = "Email that team"
type = "email"
is_default = false

settings {
"addresses" = "foo@example.net;bar@example.net"
"uploadImage" = "false"
}
}

$ terraform init
$ terraform apply

Additional Context

I am using Terraform v0.12.7, and I am not sure, which version is this docs updated for. I would request you to kindly update the Grafana_Alert docs [https://www.terraform.io/docs/providers/grafana/r/alert_notification.html] with the below provided. I have tested it out and its working seamlessly.

resource "grafana_alert_notification" "email_notification" {
name = "email_notification"
type = "email"
is_default = false

settings = {
addresses = "xyz@mail.com;abc@mail.com"
uploadImage = "false"
}
}

References

Idea from GitHub hashicorp/terraform#22095
It gave me idea to figure it out regarding the quotes, part which really helped me to rectify this.

@ashishsarkar
Copy link

Can you tell me how it could be the issue with the Provider(Grafana). As per your your Grafana Documentation, the "Example Usage" you have provided is completely wrong.

Terraform Example:(Terraform v0.12.7)

image

Correct Example(Please update in docs of Terraform Grafana Alert):

image

@mlclmj
Copy link
Contributor

mlclmj commented Apr 18, 2020

The example currently in the docs is using an old Terraform syntax which is no longer valid.

Feel free to submit a PR to update the docs to the current syntax (we have another open issue for a similar problem).

@shaun-mills
Copy link

I checked the website/docs/r/alert_notification.html.md and it seems that this has already been fixed. However the website [https://www.terraform.io/docs/providers/grafana/r/alert_notification.html] does not seem to reflect that change

hashicorp@d3c968a#diff-3cbf944d008c2d63fa3ff1191fa49e56

@tonglil
Copy link
Contributor

tonglil commented Jun 3, 2020

This should be fixed when a release of the provided is cut (see #97).

@inkel inkel self-assigned this Dec 21, 2021
@inkel
Copy link
Contributor

inkel commented Dec 22, 2021

Documentation for grafana_alert_notification is now properly updated with the right example.

Feel free to reopen this issue if your problem continues.

@inkel inkel closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants