Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenize the http proxy tests #305

Closed
pablochacin opened this issue Aug 18, 2023 · 0 comments · Fixed by #308
Closed

Homogenize the http proxy tests #305

pablochacin opened this issue Aug 18, 2023 · 0 comments · Fixed by #308
Assignees
@nadiamoe
Labels
enhancement New feature or request

Comments

@pablochacin
Copy link
Collaborator

#274 introduces a new test that uses httptest.Server for setting the test.

This approach defers from the approach used in other tests, increasing the complexity.

If using httpstest.Server is suitable for other tests, use it to have a uniform way for setting the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadiamoe nadiamoe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

agent/http: use httptest.Server for handler tests grafana/xk6-disruptor
2 participants
@pablochacin @nadiamoe