Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Site Scripting Vulnerability in SAML Auth Flow #129

Open
tylerwhardy opened this issue Sep 26, 2024 · 3 comments
Open

Cross Site Scripting Vulnerability in SAML Auth Flow #129

tylerwhardy opened this issue Sep 26, 2024 · 3 comments

Comments

@tylerwhardy
Copy link
Contributor

In the saml2/login endpoint when using 3rd party SSO, the idp parameter is vulnerable to cross-site scripting injection due to insufficient input sanitization.

Proof of Concept:
Visit the URL endpoint crypt.domain.com/saml2/login/?idp=<%2fscript><svg/onload=alert(origin)>

This will result in a XSS popup message indicating the attack worked.

This could be combined with data exfiltration Javascript or similar mechanisms to steal user data or session information.

@grahamgilbert
Copy link
Owner

The saml library we use is a third party one. Do you have any suggestions on how to remediate this?

@tylerwhardy
Copy link
Contributor Author

It looks like it was fixed in the lib on this commit:

IdentityPython/djangosaml2@b8399c9

Can you update to latest release for djangosaml2?

@grahamgilbert
Copy link
Owner

Pull requests happily accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants