Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

doesn't have provider 'cc' error with bazel-0.25.0 #25

Closed
soonho-tri opened this issue May 6, 2019 · 3 comments
Closed

doesn't have provider 'cc' error with bazel-0.25.0 #25

soonho-tri opened this issue May 6, 2019 · 3 comments

Comments

@soonho-tri
Copy link
Contributor

compile_flags = (compiler_options +
target.cc.compile_flags +
(ctx.rule.attr.copts if "copts" in dir(ctx.rule.attr) else []))

It's from the line 129, target.cc.compile_flags, which is now deprecated (from bazel-0.25.0). Please see bazelbuild/bazel#7036 for details. I think a solution is to use get_compile_flags(target) instead of target.cc.compile_flags. AFAIK, get_compile_flags is not included in bazel so we need to copy/paste it from https://gist.github.com/oquenchil/7e2c2bd761aa1341b458cc25608da50c.

@siddharthab
Copy link
Collaborator

Thank you for the report. I will most likely look at all bazel 0.25 compatibility issues in the coming weekend.

@siddharthab
Copy link
Collaborator

This is now fixed through 4a1469a and included in release 0.3.4.

Thank you for your patience.

@soonho-tri
Copy link
Contributor Author

@siddharthab , thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants