Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPAUDITLOGGING-22: Making verbose configurable per domain object - Allowing to choose what events to audit per domain obj - Issue/conflict with Shiro plugin when retrieving URI to store in the audit table #65

Open
robertoschwald opened this issue Sep 7, 2010 · 6 comments

Comments

@robertoschwald
Copy link
Contributor

Original Reporter: amalbet
Environment: Not Specified
Version: Not Specified
Migrated From: http://jira.grails.org/browse/GPAUDITLOGGING-22

I would like to propose these enhancements for next release:

  • Making verbose configurable per domain object
  • Allowing to choose what events to audit per domain obj
  • Issue/conflict with Shiro plugin when retrieving URI to store in the audit table
@robertoschwald
Copy link
Contributor Author

amalbet said:
Fix for a bug my changes introduced around loading empty ignore list. A unit test has been included too.

@robertoschwald
Copy link
Contributor Author

aeischeid said:
I would be happy to see these changes made to the plugin.

In addition I would find it useful to be able to not do audit logging in dev environment or at least not have it run during bootstrap as it causes run-app to take many minutes to complete on one of my apps.

maybe similar to verbose setting, like:

auditLog.environment.dev = false

@robertoschwald
Copy link
Contributor Author

hartsock said:
I like this suggestion. I have been racking my brains how to solve the JIRA regarding unit testing transactions. The short of it is I have to create independent transactions to get audit logging to work at all. This setting as a default would mean we could explain that the audit log behavior in test is going to be a little different (due to that separate audit log transaction business).

I am going to try and get a release out in early October I will put this feature in the new release if I can work it in.

@robertoschwald
Copy link
Contributor Author

amalbet said:
I have some integration tests I made to proof that this works... I can share it with you and may provide some help...

@robertoschwald
Copy link
Contributor Author

hartsock said:
Please do.

@robertoschwald
Copy link
Contributor Author

amalbet said:
Here is the integration test I created for an GORM obj (Evisit). It basically tests that the available configurations for the auditable setting on the domain object work in different combinations. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant