Grails apps will not deploy to Glassfish 4+

[ddelponte]

Steps to Reproduce

1. Deploy a simple Grails app war that utilizes this plugin to glassfish 4+

Expected Behaviour

The war file deploys successfully without error

Actual Behaviour

The war file does not deploy because the close() method signature in Neo4jDatastore.java throws an exception

Additional Thoughts

Methods annotated with @PreDestroy should not throw a checked exception.

Taking into account that this is a javax.* annotations and checking the documentation https://docs.oracle.com/javaee/7/api/javax/annotation/PreDestroy.html we can see that methods in the Grails source code not fully following the signature according to the Javadoc, thus we may want to adjust the signatures of the the methods that use @PreDestroy annotation by removing the checked exceptions from them.

Environment Information

• Operating System: macOS 10.13.4
• Grails Version: 3.3.5
• JDK Version: 1.8.0_171
• Container Version (If Applicable): Glassfish 4.x, Glassfish 5.x

Example Application

• https://github.com/xavier-gallofre/sec-access-issue