Revert "fix(core)!: Drop dependency grails-shell"
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a97dd3.
|
@codeconsole I found a reason to restore the The profiles plugin will be needed until grails-shell and profiles are no longer used. |
|
@jamesfredley so are you recommending we release this into 6.2.1? |
|
@codeconsole Yes, I think we should release this into 6.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #287 necessary to get IntelliJ grails plugin working again.
Do we want to bring back the profile plugins as well or just add
implementation "org.grails:grails-shell:$grailsVersion"Are we deciding to bring back the old cli completely which could be run independently via
./grailsw?