chore(stdlib)!: Add Types Aliases to regex lib #1036
Conversation
|
Alright Requested Changes Have Been Made |
|
@spotandjake The suggestion was not only to change those 2 specifically. Those variants contain comments after each that describe what the random |
Ah think I fixed my mistake there |
|
I also want to get @peblair's eyes on this since he opened the issue and wrote rege |
There was a problem hiding this comment.
@spotandjake Thanks for this PR! I spoke about the above conversation with the team, and I think we want to pare back down some of the suggested type aliases. If you could revert the following, then I think this is in a place to get merged:
- 001eeac
- 3bac01f (except we do want to retain the
@since nextchanges you made in this commit) - 6788da6
I'm pretty sure that'd cover everything. With that, I'm happy to give this a final scan and give this a final approval.
peblair
changed the title
|
@peblair feel free to review it now i reverted those changes |
| @@ -387,7 +394,7 @@ enum ParsedRegularExpression { | |||
| RELookbehind(ParsedRegularExpression, Bool, Box<Number>, Box<Number>, Number, Number), // regex, is-match, lb-min, lb-max, n-start, num-n (lb-xx values patched in later) | |||
| RECut(ParsedRegularExpression, Number, Number, Bool), // regex, n-start, num-n, needs-backtrack | |||
| REReference(Number, Bool), // n, case-sensitive | |||
| RERange(List<(Number, Number)>), | |||
| RERange(RERange), | |||
There was a problem hiding this comment.
How is RERange(RERange) used? Do consumers need to have access to the list?
closes: #692 .