Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stdlib)!: Change Buffer#addStringSlice API #1136

Merged
merged 1 commit into from
Mar 4, 2022
Merged

fix(stdlib)!: Change Buffer#addStringSlice API #1136

merged 1 commit into from
Mar 4, 2022

Conversation

peblair
Copy link
Member

@peblair peblair commented Feb 23, 2022

This PR changes the semantics of Buffer#addStringSlice to align with those of String#slice.

Closes #1071.

@peblair peblair requested a review from a team February 23, 2022 14:15
phated
phated approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Excellent!

@phated phated requested a review from a team March 3, 2022 17:53
marcusroberts
marcusroberts approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@phated phated merged commit 0c7cb82 into main Mar 4, 2022
@phated phated deleted the philip/change-slice-api branch March 4, 2022 20:40
@github-actions github-actions bot mentioned this pull request Mar 4, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 16, 2022
Closed
@phated phated mentioned this pull request May 30, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 31, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jul 25, 2022
Closed
This was referenced Mar 20, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@ospencer ospencer ospencer approved these changes

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String.slice and Buffer.addStringSlice have different API signatures
4 participants
@peblair @phated @ospencer @marcusroberts