Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Respect stack type when dropping statements #1138

Merged
merged 1 commit into from
Mar 6, 2022
Merged

fix(compiler): Respect stack type when dropping statements #1138

merged 1 commit into from
Mar 6, 2022

Conversation

ospencer
Copy link
Member

No description provided.

@ospencer ospencer requested a review from a team February 27, 2022 16:12
@ospencer ospencer self-assigned this Feb 27, 2022
@ospencer ospencer force-pushed the oscar/unsafe-string branch 2 times, most recently from 0d68959 to ee6fce8 Compare February 27, 2022 19:42
@ospencer ospencer force-pushed the oscar/stack-type-drop branch 2 times, most recently from 4c1122e to 4dd649e Compare February 27, 2022 22:20
marcusroberts
marcusroberts approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I can read the snapshots very well but the code change looks good.

phated
phated approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Skimmed the snapshots too

compiler/src/codegen/transl_anf.re Show resolved Hide resolved
@ospencer ospencer changed the base branch from oscar/unsafe-string to main March 6, 2022 03:42
@ospencer ospencer merged commit 5a44e93 into main Mar 6, 2022
@ospencer ospencer deleted the oscar/stack-type-drop branch March 6, 2022 03:55
@github-actions github-actions bot mentioned this pull request May 16, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@peblair peblair peblair approved these changes

@phated phated phated approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ospencer @phated @peblair @marcusroberts