feat(compiler): Convert runtime/dataStructures.gr to primitives
#1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
force-pushed
the
oscar/unsafe-number
branch
from
a897a16
to
f8a56a9
Compare
ospencer
force-pushed
the
oscar/data-structures-primitives
branch
from
a48dd60
to
ff0478f
Compare
ospencer
force-pushed
the
oscar/unsafe-number
branch
from
f8a56a9
to
02a1afe
Compare
ospencer
force-pushed
the
oscar/data-structures-primitives
branch
from
ff0478f
to
7c4aa62
Compare
marcusroberts
approved these changes
Mar 4, 2022
phated
requested changes
Mar 5, 2022
| Types.StackAllocated(WasmI32), | ||
| Types.StackAllocated(WasmI32), | ||
| ], | ||
| [Types.HeapAllocated, Types.HeapAllocated, Types.HeapAllocated], |
There was a problem hiding this comment.
Why is this changed to heap allocated?
There was a problem hiding this comment.
Was just wrong before. This is a little bit of a subtle bug to catch too, since it'd only be a problem if you were pattern matching on heap-allocated constants. I only noticed it because of the refactor.
stdlib/runtime/dataStructures.gr
Outdated
| * | ||
| * @returns {WasmI32} | ||
| * @returns |
stdlib/runtime/dataStructures.gr
Outdated
| * | ||
| * @returns {WasmI32} | ||
| * @returns |
stdlib/runtime/dataStructures.gr
Outdated
| ptr | ||
| } | ||
| @unsafe | ||
| export primitive allocateRational: () -> WasmI32 = "@allocate.rational" | ||
|
|
||
| /** | ||
| * Allocates a new Rational with a prepopulated value | ||
| * @param value The value to store |
There was a problem hiding this comment.
Wrong docs? Can you please update
stdlib/runtime/dataStructures.gr
Outdated
| * @param wrappedRational The boxed rational to return | ||
| * Load the (tagged) variant of an ADT. | ||
| * | ||
| * @export |
stdlib/runtime/dataStructures.gr
Outdated
| * @param wrappedRational The boxed rational to return | ||
| * Load an untagged string's size. | ||
| * | ||
| * @export |
stdlib/runtime/dataStructures.gr
Outdated
|
|
||
| /** | ||
| * Load a value from an ADT. | ||
| * Load an untagged Bytes' size. | ||
| * | ||
| * @export |
stdlib/runtime/dataStructures.gr
Outdated
|
|
||
| /** | ||
| * Load an untagged string's size. | ||
| * Untag a simple number. | ||
| * | ||
| * @export |
phated
requested changes
Mar 5, 2022
|
@phated Let me know if that looks good. |
phated
approved these changes
Mar 6, 2022
ospencer
force-pushed
the
oscar/unsafe-number
branch
3 times, most recently
from
bad2609
to
6c2d1d9
Compare
ospencer
force-pushed
the
oscar/data-structures-primitives
branch
from
3f278be
to
66c0bab
Compare
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
ospencer
force-pushed
the
oscar/data-structures-primitives
branch
from
66c0bab
to
03f8232
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that all of the data structures functions get inlined, so there's no performance cost to using something like
untagNumber.