Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoketest for runtimes with limited features #1160

Closed
ospencer opened this issue Mar 7, 2022 · 2 comments · Fixed by #1255
Closed

Add smoketest for runtimes with limited features #1160

ospencer opened this issue Mar 7, 2022 · 2 comments · Fixed by #1255
Assignees

Comments

@ospencer
Copy link
Member

ospencer commented Mar 7, 2022

We currently use the multivalue feature of Binaryen to manipulate the wasm stack via tuples, but don't utilize any multivalue functions. Because the flag for multivalue is turned on, Binaryen may perform an optimization that would introduce a multivalue function/type. This test would verify that this doesn't occur using a runtime that doesn't support multivalue, like Node 14 or the NEAR runner.

@phated
Copy link
Member

phated commented May 10, 2022

My thoughts here are that we should use https://github.com/near/workspaces-js to write a "test" for a simple "hello world" grain program. I believe we can get by with the SandboxWorker version as long as we are running on linux CI.

@phated
Copy link
Member

phated commented May 12, 2022

Here is an example contract: https://github.com/grain-lang/near-simple-counter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants