Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Support pattern aliases #1174

Merged
merged 3 commits into from
Apr 21, 2022
Merged

feat(compiler): Support pattern aliases #1174

merged 3 commits into from
Apr 21, 2022

Conversation

ospencer
Copy link
Member

No description provided.

@ospencer ospencer requested a review from a team March 20, 2022 22:45
@ospencer ospencer self-assigned this Mar 20, 2022
peblair
peblair approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@peblair peblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnifique 👏 🥸

@jozanza jozanza self-requested a review March 31, 2022 16:16
@marcusroberts
Copy link
Member

Does the formatter need updating for this?

jozanza
jozanza approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@jozanza jozanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

phated
phated requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome! I just want a runnable test to know that constant or-pattern alias is doing what I expect

compiler/test/suites/pattern_matching.re Outdated Show resolved Hide resolved
@ospencer ospencer requested a review from phated April 15, 2022 22:31
Base automatically changed from oscar/or-patterns to main April 20, 2022 23:41
phated
phated approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge approval from me!

@ospencer ospencer merged commit 9ed093b into main Apr 21, 2022
@ospencer ospencer deleted the oscar/alias-patterns branch April 21, 2022 14:55
@github-actions github-actions bot mentioned this pull request May 16, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jozanza jozanza jozanza approved these changes

@phated phated phated approved these changes

@peblair peblair peblair approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ospencer @marcusroberts @jozanza @phated @peblair