feat(compiler): Call known functions across module boundaries #1175
Conversation
ospencer
force-pushed
the
oscar/call-known-across-modules
branch
from
7447bb8
to
19e7a76
Compare
| mimp_used: true, | ||
| }, | ||
| ], | ||
| ) | ||
| | FunctionShape(_) => |
There was a problem hiding this comment.
Can you explain FunctionShape to me a bit? Since it seems like we're adding support that we didn't have before
There was a problem hiding this comment.
Of course! Imports take one of two shapes, GlobalShape or FunctionShape, corresponding to wasm globals or wasm functions. Imports that happen via foreign wasm are either GlobalShape or FunctionShape, and before this PR, Grain imports were only GlobalShape, meaning that imported functions were only ever imported as values—the closure for the function. This meant that the only way the function could be called was via a call_indirect.
This change allows us say that we're importing an actual Grain webassembly function (and its closure), so we can call it via a regular call instruction rather than having to pull the pointer from the closure.
This PR uses regular
calls where possible between modules. This should be fairly significant for performance, as directcalls are much faster thancall_indirects. Additionally, Binaryen can now provide better optimizations after linking.