feat(compiler): Allow function re-exports to use regular call instruction #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peblair
reviewed
Mar 22, 2022
| { | ||
| val_repr: ReprFunction(args, rets, _), | ||
| val_fullpath: Path.PIdent(id), | ||
| } as vd, | ||
| ) => { | ||
| switch (Ident_tbl.find_opt(func_map, id)) { | ||
| | Some({name: Some(name)}) => | ||
| | Some(internal_name) => | ||
| let external_name = Ident.name(vid); |
There was a problem hiding this comment.
What's the significance of changing to vid instead of id here (and line 1293)?
There was a problem hiding this comment.
This way is "guaranteed" to be correct, since it's the name that's included in the module signature rather than the name that's a part of the full path (which is something internal). 1293 was really just a bug 😶
I guess it wasn't really a bug since it doesn't affect anything, but id could potentially be incorrect.
| /* Exports are already reversed, so keeping the first of any name is the correct behavior. */ | ||
| List.filter( | ||
| ({ex_name}) => | ||
| if (Hashtbl.mem(exported, Ident.name(ex_name))) { | ||
| fun |
There was a problem hiding this comment.
Is this just removing duplicates (this question probably belongs on the other PR)?
There was a problem hiding this comment.
Yeah, that's it. The work it does is a bit different now since the names are already supplied.
marcusroberts
approved these changes
Apr 5, 2022
ospencer
force-pushed
the
oscar/call-known-across-modules
branch
from
7447bb8
to
19e7a76
Compare
ospencer
force-pushed
the
oscar/function-reexport
branch
from
20c9221
to
6159ee4
Compare
peblair
approved these changes
Apr 16, 2022
phated
requested changes
Apr 21, 2022
ospencer
force-pushed
the
oscar/function-reexport
branch
from
6159ee4
to
7dfc921
Compare
phated
approved these changes
Apr 21, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.