Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Supply correct error for unbound record labels #1200

Merged
merged 1 commit into from
May 14, 2022

Conversation

ospencer
Copy link
Member

Fixes #1000

@ospencer ospencer requested a review from a team April 27, 2022 03:33
@ospencer ospencer self-assigned this Apr 27, 2022
@ospencer ospencer force-pushed the oscar/fix-record-label-error branch from 146322b to cbe2226 Compare May 7, 2022 15:12
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird to say "record" when the value isn't, but better than what we have now.

Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ospencer ospencer merged commit 86e1bc0 into main May 14, 2022
@ospencer ospencer deleted the oscar/fix-record-label-error branch May 14, 2022 17:43
@github-actions github-actions bot mentioned this pull request May 16, 2022
@github-actions github-actions bot mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very unfriendly compiler error
3 participants