Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grainfmt): Properly handle if/then/else line breaks #1217

Merged
merged 1 commit into from
May 12, 2022
Merged

fix(grainfmt): Properly handle if/then/else line breaks #1217

merged 1 commit into from
May 12, 2022

Conversation

marcusroberts
Copy link
Member

Fixes an edge case where if/then/else where then is a block and else is a single line

@marcusroberts marcusroberts changed the title Fix a formatter error fix:(compiler): formatter error on if/then/else May 12, 2022
marcusroberts pushed a commit that referenced this pull request May 12, 2022
Removed a fix, moved into PR #1217
8f38552
@marcusroberts marcusroberts changed the title fix:(compiler): formatter error on if/then/else fix:(grainfmt): formatter error on if/then/else May 12, 2022
@phated phated changed the title fix:(grainfmt): formatter error on if/then/else fix(grainfmt): Properly handle if/then/else May 12, 2022
@phated phated changed the title fix(grainfmt): Properly handle if/then/else fix(grainfmt): Properly handle if/then/else line breaks May 12, 2022
phated
phated approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@marcusroberts marcusroberts merged commit 93fd3b5 into main May 12, 2022
@marcusroberts marcusroberts deleted the marcus/fix_if_else_format branch May 12, 2022 18:52
@github-actions github-actions bot mentioned this pull request May 16, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcusroberts @phated @ospencer