feat(compiler): Refactor exports #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
force-pushed
the
oscar/refactor-exports
branch
from
12a134f
to
a88e1a6
Compare
phated
reviewed
May 22, 2022
| @@ -14,21 +17,61 @@ let safe_to_remove_import = i => | |||
| | _ => false | |||
| }; | |||
|
|
|||
| let is_used = ident => | |||
| Option.is_some(Ident.find_same_opt(ident, used_symbols^)); | |||
There was a problem hiding this comment.
We should add some utilities to the Ident module (like contains). Probably not needed in this PR.
ospencer
force-pushed
the
oscar/refactor-exports
branch
from
a88e1a6
to
cc456d9
Compare
ospencer
force-pushed
the
oscar/refactor-exports
branch
from
cc456d9
to
2e74700
Compare
peblair
reviewed
May 25, 2022
| | Path.PExternal(Path.PIdent(mod_) as p, ident, _) => | ||
| let allocation_type = get_allocation_type(env, val_type); | ||
| let mod_decl = Env.find_module(p, None, env); | ||
| // Lookup external exports to import them into the module |
There was a problem hiding this comment.
I'm a little confused what this is doing. Can you clarify a little more?
There was a problem hiding this comment.
Yeah! So the way imports actually make it into the WebAssembly module is via lookup_symbol registering the individual values and functions to include them in the module. Previously doing export foo was sugar for export let foo = foo, making foo get used and thus be included as an import, but now an export statement skips the extra binding. The lookup here is effectively us saying that we plan to use that value so it actually gets imported.
marcusroberts
approved these changes
May 26, 2022
peblair
approved these changes
May 26, 2022
ospencer
force-pushed
the
oscar/refactor-exports
branch
from
2e74700
to
4074f39
Compare
This was referenced May 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how exports are compiled in Grain. Namely,
will now properly result in a type error, whereas previously
barwas unexpectedly in scope.Because of these changes, the hello world module size is reduced again by 25%, coming in under 39k.