fix(compiler): Report Win32 instead of Cygwin in JS compiler #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
approved these changes
May 24, 2022
marcusroberts
approved these changes
May 24, 2022
|
Looks like this might be causing a bug in the relative import resolution. I'll need to debug before we can land it. |
phated
force-pushed
the
phated/jsoo-os-type
branch
from
0812b9e
to
6810f76
Compare
phated
force-pushed
the
phated/jsoo-os-type
branch
from
b8486db
to
52f77c7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS version of the compiler kept crashing because it was unable to locate the stdlib. This was due to JSOO reporting itself as "Cygwin" instead of "Win32". We've pushed for a lot of upstream changes in
Fpso we use the correct separators on Windows, but that doesn't happen if it thinks it is running in Cygwin.This hack (placed in
Grain_utilsso pretty much everything will get it applied) will swap us back to reportingWin32and make the all our tools work.