chore(compiler)!: Refactor HeapAllocated/StackAllocated into Managed/Unmanaged #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
approved these changes
May 27, 2022
marcusroberts
approved these changes
May 29, 2022
peblair
approved these changes
May 29, 2022
|
@ospencer Not breaking? Changes to the CMI should be, no? |
|
Some CMI changes aren't breaking (the modules just get recompiled if there's an old version/mismatch). This one's borderline for if someone was relying on that CMI information, so I'll just mark it breaking. |
ospencer
changed the title
Closed
Merged
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes CMI size a tad smaller too.
Closes #1154