fix(cli)!: Show all global options within help for every command #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this approach! |
| run(wasmFile, program.opts()); | ||
| }); | ||
| .addOption(new commander.Option("-p, --print-output").hideHelp()) | ||
| .action(run); | ||
|
|
||
| program | ||
| .command("lsp <file>") |
There was a problem hiding this comment.
Will need to remember to update this for the new LSP
There was a problem hiding this comment.
Yeah, I've been doing the merge and resolves
ospencer
approved these changes
May 30, 2022
marcusroberts
approved these changes
May 30, 2022
peblair
approved these changes
Jun 1, 2022
Merged
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1080
Closes #1147 (I think?)
This PR reworks our commander stuff in the CLI so we show all global options for the root/default command and all subcommands. It also allows subcommands to specify specific options they need, which you'll notice with the different
-ooptions throughout the CLI (some that require only files and some that allow directories or files).This is a pretty hefty PR, so I hope I didn't miss anything. Please give it a thorough review and test combinations of flags with various commands. I tested with
--releaseand--no-linkduring development.This PR is marked as breaking because the changes caused the tests to fail, which made me realize we were generating this command
grain -S /path/to/stdlib -I /path/to/test/includes run test-file.gr. We no longer allow options before the subcommands because otherwise our CLI thinks you are running the root command and thatrunis supposed to be a file.Here are what some of the
--helpusages output: