feat(ci): Link all versions during release #1290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
release-please
tool we use to v13 (v3.x of the action), which requires us to switch up the uploader actions to the one I built for libbinaryen and binaryen.ml.The upgrade was primarily to switch from the
node-workspace
plugin to thelinked-versions
plugin so the version of every package is exactly the same. We still need to update the versions inside our@grain/cli
dependencies, so I'm using theextra-files
feature of release-please to update those versions, which means we no longer use a caret on those versions.I encountered various problems when updating all of this:
filename
property innpm pack
output: [BUG]npm pack
incorrect filename for scoped package npm/cli#3405grouped-pull-request-title
,linked-versions
andnode-workspace
:group-pull-request-title-pattern
doesn't work withlinked-versions
plugin googleapis/release-please#1456linked-versions
andnode-workspace
, requiring us to useextra-files
:linked-versions
andnode-workspace
plugins are incompatible googleapis/release-please#1457You can see an example of the "linked-versions" PR at phated#2 (notice the various "Synchronize Grain versions" changelog entries).
And you can see an example of a full release at https://github.com/phated/grain/actions/runs/2411992148 (the docker dispatch failed because I disabled the docker workflow in my branch)