Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grainformat: Extra newlines between comments #1310

Closed
phated opened this issue Jun 5, 2022 · 1 comment · Fixed by #1436
Closed

Grainformat: Extra newlines between comments #1310

phated opened this issue Jun 5, 2022 · 1 comment · Fixed by #1436
Assignees

Comments

@phated
Copy link
Member

phated commented Jun 5, 2022

When two comments come after one another, grainformat will add extra newlines between them. This is a problem because it breaks graindoc.

Here's an example:

/**
 * Some graindoc documentation
 *
 * @param foo: bar
 * @returns foo
 */
// TODO: We need to do something
let baz = foo => foo

In the above example, formatting the code will insert an empty line between the graindoc comment and // TODO comment. Graindoc only works if it is on 1 (or 2 because of annotations) lines before the definition.

@marcusroberts marcusroberts self-assigned this Sep 8, 2022
@marcusroberts
Copy link
Member

Confirmed it still does this, working to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants