Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Support record field updating assignment #1320

Merged
merged 4 commits into from
Jun 13, 2022
Merged

feat(compiler): Support record field updating assignment #1320

merged 4 commits into from
Jun 13, 2022

Conversation

ospencer
Copy link
Member

Closes #1318

@ospencer ospencer requested a review from a team June 11, 2022 22:01
@ospencer ospencer self-assigned this Jun 11, 2022
@phated
Copy link
Member

phated commented Jun 11, 2022

Looks like this needs parser message updates?

@ospencer
Copy link
Member Author

Done.

phated
phated approved these changes Jun 12, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks for digging into this ❤️

@ospencer ospencer merged commit cc5519c into main Jun 13, 2022
@ospencer ospencer deleted the oscar/support-record-update-assign branch June 13, 2022 14:21
@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@peblair peblair peblair approved these changes

@phated phated phated approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support += with record
4 participants
@ospencer @phated @peblair @marcusroberts