fix(grainfmt): Format rational numbers with parens when needed for precedence #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusroberts
changed the title
ospencer
force-pushed
the
marcus/fix_rational_number_format
branch
4 times, most recently
from
b6477e7
to
bdda868
Compare
ospencer
force-pushed
the
marcus/fix_rational_number_format
branch
from
bdda868
to
44c10df
Compare
ospencer
approved these changes
Jul 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1374
When formatting rational numbers, add a parens when the number is on the rhs to ensure correct precedence
The numbers test suite is formatted and passed, but please check for style