-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib): Implement immutable map and immutable set #1414
feat(stdlib): Implement immutable map and immutable set #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! A couple of small things but otherwise this is excellent 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the review delay here! This looks absolutely fantastic 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is excellent! I ran into a few things while reviewing and commented inline. Thanks for all your work and I'm excited to get this updated and merged 🎉
a53f246
to
2047f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change and I think we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the awesome work on this! 🎉
I figured I'd include both maps and sets in one PR since their implementation is almost identical. They are both implemented as size-balanced BSTs, following "Implementing Sets Efficiently in a Functional Language" by Stephen Adams. API for these is as was discussed in #1403