Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Use option converter instead of Some #1432

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

renatoalencar
Copy link
Contributor

When trying to use --help for grainc, this makes the docs printer for enum look for a None value on the enum list, which yields an Invalid_argument exception, crashing the grainc executable.

When trying to use --help for grainc, this makes the docs printer for
enum look for a None value on the
enum list, which yields an Invalid_argument
exception, crashing the grainc executable.
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Thanks!

@phated phated merged commit 57776f2 into grain-lang:main Sep 6, 2022
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants