fix(stdlib): Fix anchoring behavior in Regex.replaceAll #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peblair
commented
Oct 3, 2022
| let poss = searchMatch( | ||
| rx, | ||
| buf, | ||
| searchPos, | ||
| searchPos, |
There was a problem hiding this comment.
This was breaking the anchoring behavior, since the "am I at the start of the input?" check always succeeded due to us saying that the input started at searchPos (the current position). For the regular expression ^., the lookbehind is 1, so this will be 0 when searchPos == 0 and searchPos - 1 for every other position.
ospencer
approved these changes
Oct 3, 2022
phated
approved these changes
Oct 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1431.