Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Add replacement functions to String module #1441

Merged
merged 11 commits into from
Nov 8, 2022
Merged

feat(stdlib): Add replacement functions to String module #1441

merged 11 commits into from
Nov 8, 2022

Conversation

spotandjake
Copy link
Member

@spotandjake spotandjake commented Oct 3, 2022 •
edited
Loading

This pr implements String.replaceFirst and String.replaceLastand String.replaceAll. let me know if you guys want the naming scheme to be changed.

ospencer
ospencer requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a couple of tweaks and this is perfect code-wise 🙂

stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
@spotandjake spotandjake changed the title feat(stdlib): Implement replaceFirst and replaceLast feat(stdlib): Implement replaceFirst and replaceLast and replaceAll Oct 4, 2022
ospencer
ospencer requested changes Oct 14, 2022
View reviewed changes
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
ospencer
ospencer reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more updates to the comments, but otherwise looks great :)

stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
@spotandjake @ospencer
Apply suggestions from code review
3da26ba 
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
@spotandjake
Copy link
Member Author

Applied Those Changes

@ospencer ospencer changed the title feat(stdlib): Implement replaceFirst and replaceLast and replaceAll feat(stdlib): Implement String.replaceFirst, String.replaceLast, and String.replaceAll Oct 19, 2022
ospencer
ospencer approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @spotandjake!

@ospencer ospencer requested a review from a team November 7, 2022 23:16
@spotandjake @phated
chore: Apply Suggested Change From Code Review
4373334 
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
@spotandjake
Copy link
Member Author

Applied That Change

phated
phated requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some docs work and you added a file that shouldn't be here. Please be careful when committing!

compiler/test/stdlib/string.test.gr Show resolved Hide resolved
compiler/test/stdlib/string.test.gr Outdated Show resolved Hide resolved
compiler/test/stdlib/string.test.gr Show resolved Hide resolved
compiler/test/stdlib/string.test.gr Outdated Show resolved Hide resolved
compiler/test/stdlib/string.test.gr Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
stdlib/string.gr Outdated Show resolved Hide resolved
string.md Outdated Show resolved Hide resolved
@phated phated changed the title feat(stdlib): Implement String.replaceFirst, String.replaceLast, and String.replaceAll feat(stdlib): Add replacement functions to String module Nov 8, 2022
@spotandjake
Copy link
Member Author

Applied Those Suggestions

phated
phated reviewed Nov 8, 2022
View reviewed changes
stdlib/string.gr Outdated Show resolved Hide resolved
phated
phated reviewed Nov 8, 2022
View reviewed changes
stdlib/string.gr Outdated Show resolved Hide resolved
phated
phated reviewed Nov 8, 2022
View reviewed changes
stdlib/string.gr Outdated Show resolved Hide resolved
phated
phated approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @spotandjake

@phated phated merged commit 5606cd2 into grain-lang:main Nov 8, 2022
@github-actions github-actions bot mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@ospencer ospencer ospencer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spotandjake @phated @ospencer