Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler)!: Add additional reserved keywords #1471

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

spotandjake
Copy link
Member

@spotandjake spotandjake commented Nov 7, 2022

Added module, macro, yield to Reserved Keywords List, with the goal of making future breaking changes less intrusive.

If there are any additional reserved keywords that would make sense to add let me know.

Closes: #1463

@ospencer ospencer changed the title feat(compiler)!: Add Aditional Reserved Keywords feat(compiler)!: Add additional reserved keywords Nov 7, 2022
@ospencer ospencer requested a review from a team November 7, 2022 23:13
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sold on these keywords so I don't really want to reserve them.

compiler/src/parsing/lexer.re Outdated Show resolved Hide resolved
@spotandjake
Copy link
Member Author

Made those changes

compiler/src/parsing/lexer.re Outdated Show resolved Hide resolved
compiler/src/parsing/parser.mly Outdated Show resolved Hide resolved
spotandjake and others added 4 commits January 11, 2023 15:51
Add `async`, `await`, `module`, `macro`, `yield` to Reserved Keywords List
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
@spotandjake spotandjake force-pushed the spotandjake-add-reserved-keywords branch from 2689063 to d167d0a Compare January 11, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Lexer: Add Reserved Keywords
5 participants