feat(stdlib)!: Make queue and stack mutable & provide Immutable submodules #1479
Conversation
|
@alex-snezhko I think we're going to hold this PR back from 0.5.5 because we think it is confusing to have Queue and Stack be the immutable versions but Map & Set are mutable (and then have the inverse have the special naming). We're going to deprecated the immutable Queue & Stack in 0.5.5 and then have you make this the breaking change that moves stuff around. How does that sound? |
|
Sounds good! |
phated
changed the title
alex-snezhko
force-pushed
the
mutable-queue-stack
branch
from
33cb48c
to
9fdc216
Compare
alex-snezhko
requested review from
ospencer,
phated,
peblair and
jozanza
as code owners
alex-snezhko
force-pushed
the
mutable-queue-stack
branch
from
9fdc216
to
fa1b64c
Compare
phated
force-pushed
the
mutable-queue-stack
branch
from
c7426bb
to
4dfc7c5
Compare
There was a problem hiding this comment.
@alex-snezhko I've rebased this so I could generate the docs with my submodule support in #1684 - however, I think you need to update the @since and @history for the various things that moved around. e.g. Since functions moved from the root into the Immutable submodule, I think those should be @since v0.6.0 with a history item saying they were originally a root API (similar to how we did those other PRs).
alex-snezhko
force-pushed
the
mutable-queue-stack
branch
from
7332ebc
to
487aedd
Compare
phated
force-pushed
the
mutable-queue-stack
branch
from
487aedd
to
34c824e
Compare
|
Rebased again and regenerated the docs with graindoc fixes. |
phated
changed the title
|
Also looks like the set tests need to be formatted. |
|
Thanks @phated :) |
…dules (grain-lang#1479) * feat(stdlib): Mutable queue and stack * moved mutable impls to root of modules * generate submodule docs with graindoc submodule support * updated history * update docs with graindoc fixes * formatting * update names as per review --------- Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
Mutable array-based implementations for queues and stacks. From a few benchmarks these implementations offer much faster performance than the current immutable
QueueandStackimplementations (likely due to gains in cache locality because of underlying array representation), which may make them more viable for performance-sensitive applications.