Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grainfmt): Reduce binop format time #1482

Merged
merged 3 commits into from
Nov 18, 2022
Merged

fix(grainfmt): Reduce binop format time #1482

merged 3 commits into from
Nov 18, 2022

Conversation

ospencer
Copy link
Member

Because the call to print_expression was outside of the if, we got combinatorial blowup when processing binops. Moving the call to inside the if prevents this.

@ospencer ospencer requested a review from a team November 17, 2022 01:51
@ospencer ospencer self-assigned this Nov 17, 2022
marcusroberts
marcusroberts approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

phated
phated approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this @ospencer ❤️

@ospencer ospencer merged commit e850455 into main Nov 18, 2022
@ospencer ospencer deleted the oscar/format-perf-regression branch November 18, 2022 17:22
@github-actions github-actions bot mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@phated phated phated approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ospencer @phated @marcusroberts