Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Perform partial match checking on let-binds #1486

Merged
merged 2 commits into from
Nov 29, 2022
Merged

fix(compiler): Perform partial match checking on let-binds #1486

merged 2 commits into from
Nov 29, 2022

Conversation

peblair
Copy link
Member

@peblair peblair commented Nov 20, 2022 •
edited
Loading

Fixes #1453.

New warnings with the fix:
image

@peblair peblair requested a review from a team November 20, 2022 18:01
phated
phated approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about cleaning up some commented code but otherwise this looks great to me ❤️

compiler/src/typed/typecore.re Show resolved Hide resolved
@phated phated merged commit 3678eb5 into main Nov 29, 2022
@phated phated deleted the philip/let-bind-partial-checking branch November 29, 2022 00:23
@github-actions github-actions bot mentioned this pull request Nov 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Grain v0.5.5
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-exhaustive pattern match missing warning
4 participants
@peblair @phated @ospencer @marcusroberts