Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grainfmt): Handle comment in or near if conditionals better #1513

Merged
merged 2 commits into from
Dec 3, 2022
Merged

fix(grainfmt): Handle comment in or near if conditionals better #1513

merged 2 commits into from
Dec 3, 2022

Conversation

marcusroberts
Copy link
Member

Fixes #1445

As we can't tell from the AST if a trailing comment is inside or outside the parens, we always render it inside

ospencer
ospencer approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@phated phated merged commit 8a60985 into main Dec 3, 2022
@phated phated deleted the marcus/issue_1445 branch December 3, 2022 23:52
@github-actions github-actions bot mentioned this pull request Dec 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@ospencer ospencer ospencer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatter: Issue Code Formatting
3 participants
@marcusroberts @phated @ospencer