fix(grainfmt): nicer pretty printing of binops #1514
Merged
+132
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusroberts
changed the title
ospencer
reviewed
Dec 3, 2022
| | "&&" | ||
| | "||" => true | ||
| | _ => false | ||
| }; |
There was a problem hiding this comment.
These two functions need to be extended to the start of the operators in the same way that op_precedence does, but otherwise this looks good.
ospencer
reviewed
Dec 3, 2022
ospencer
reviewed
Dec 3, 2022
|
|
||
| let ya = 1 / (2 + 3) | ||
|
|
||
| let y1 = 1 + 2 /3 |
There was a problem hiding this comment.
Oh that's because constants are formatted as-is and it's a rational literal. I'll open an issue about that separately.
Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
ospencer
approved these changes
Dec 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1391
Add additional parens to binary operators for clarity when precedence is the same but operators are different.
Except for maths operators, and when the right hand operator is a logical operator