Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Number.parse #1517

Merged
merged 5 commits into from
Dec 4, 2022
Merged

feat(stdlib): Number.parse #1517

merged 5 commits into from
Dec 4, 2022

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Dec 3, 2022

No description provided.

@ospencer ospencer requested a review from a team December 3, 2022 20:52
@ospencer ospencer self-assigned this Dec 3, 2022
marcusroberts
marcusroberts approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That LGTM!

Base automatically changed from parse-float to main December 3, 2022 23:46
@phated phated linked an issue Dec 4, 2022 that may be closed by this pull request
Stdlib: Need a way to parse a string into a number #452
Closed
phated
phated approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah! Closing #452 (so old!)

@phated phated merged commit 59e89d1 into main Dec 4, 2022
@phated phated deleted the oscar/parse-number branch December 4, 2022 01:58
@github-actions github-actions bot mentioned this pull request Dec 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts approved these changes

@phated phated phated approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stdlib: Need a way to parse a string into a number
3 participants
@ospencer @phated @marcusroberts