Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grainfmt): Maintain comments in function arguments #1527

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

marcusroberts
Copy link
Member

Fixes #983

Use the new iterator to format function arguments in function application

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment!

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcusroberts!

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@phated phated merged commit 6ad6dc1 into main Dec 5, 2022
@phated phated deleted the marcus/issue_983 branch December 5, 2022 00:22
@github-actions github-actions bot mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grainfmt: Comment in between arguments on own lines gets moved to weird place
3 participants