Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Properly parse large hex numbers #1546

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix(compiler): Properly parse large hex numbers #1546

merged 1 commit into from
Dec 14, 2022

Conversation

ospencer
Copy link
Member

This makes 0xffff_ffff_ffff_ffff parse (correctly) as 18446744073709551615 and -0xffff_ffff_ffff_ffff as -18446744073709551615. Shoutout to @alex-snezhko for discovering this one.

@ospencer ospencer requested a review from a team December 10, 2022 21:42
@ospencer ospencer self-assigned this Dec 10, 2022
peblair
peblair approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@peblair peblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

@phated phated merged commit 5f8d770 into main Dec 14, 2022
@phated phated deleted the oscar/fix-hex-bigint-parsing branch December 14, 2022 20:49
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@peblair peblair peblair approved these changes

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ospencer @phated @peblair