Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Record spread syntax #1565

Merged
merged 3 commits into from
Jan 7, 2023
Merged

feat(compiler): Record spread syntax #1565

merged 3 commits into from
Jan 7, 2023

Conversation

alex-snezhko
Copy link
Member

Syntax for creating a copy of a record while changing some field values. Currently the "naive" approach of copying fields one at a time is used, but bulk copying was discussed as a possible future improvement.

Closes #778

@alex-snezhko alex-snezhko changed the title Record spread feat(compiler): Record spread syntax Dec 30, 2022
ospencer
ospencer reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really stellar! Just a couple of questions from me but this looks like it'll be ready to land pretty soon :)

compiler/src/parsing/ast_helper.re Outdated Show resolved Hide resolved
compiler/src/parsing/parser.messages Outdated Show resolved Hide resolved
compiler/src/parsing/parser.messages Show resolved Hide resolved
compiler/src/parsing/parser.messages Outdated Show resolved Hide resolved
compiler/src/typed/typecore.re Outdated Show resolved Hide resolved
phated
phated requested changes Dec 30, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I saw from my phone

compiler/test/formatter_outputs/records.gr Outdated Show resolved Hide resolved
ospencer
ospencer approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alex-snezhko! Awesome work here 😄

@ospencer ospencer requested a review from phated January 5, 2023 22:56
@ospencer
Copy link
Member

ospencer commented Jan 5, 2023

Looks like you need a npm run compiler format.

@ospencer
Copy link
Member

ospencer commented Jan 5, 2023

Jinx :P

phated
phated requested changes Jan 5, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fantastic. I saw a few things (mostly questions) but overall it was a delight to review!

compiler/src/middle_end/linearize.re Outdated Show resolved Hide resolved
compiler/src/middle_end/linearize.re Show resolved Hide resolved
compiler/src/parsing/ast_helper.re Outdated Show resolved Hide resolved
compiler/src/parsing/parser.messages Show resolved Hide resolved
phated
phated approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ospencer ospencer merged commit ab60e12 into grain-lang:main Jan 7, 2023
@github-actions github-actions bot mentioned this pull request Jan 7, 2023
Merged
@ospencer ospencer mentioned this pull request Jan 8, 2023
Open
marcusroberts pushed a commit that referenced this pull request Jan 14, 2023
@alex-snezhko
feat(compiler): Record spread syntax (#1565)
66eaabd 
Closes #778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

@phated phated phated approved these changes

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

Assignees

@alex-snezhko alex-snezhko

Labels
None yet
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record spread syntax
4 participants
@alex-snezhko @ospencer @phated @marcusroberts