feat(compiler)!: Enable tail calls by default #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
force-pushed
the
spotandjake-default-tail-calls
branch
from
b2868c2
to
63b97ee
Compare
|
@phated (apologies if this duplicates Discord discussion) What do you recommend we do about the NEAR smoketest here? Aside from the failing CI, this looks good. |
|
I was thinking we could pass in the compiler flag to not use tail calls for those tests. But was wondering the same thing, should be as simple as changing |
spotandjake
force-pushed
the
spotandjake-default-tail-calls
branch
2 times, most recently
from
b50569c
to
23b74bf
Compare
ospencer
changed the title
--experimental-wasm-tail-call with --no-wasm-tail-call; enable tail calls by default
spotandjake
force-pushed
the
spotandjake-default-tail-calls
branch
from
20cbd09
to
3a7f94d
Compare
spotandjake
requested review from
phated,
ospencer,
marcusroberts,
peblair and
jozanza
as code owners
|
@ospencer The
|
phated
force-pushed
the
spotandjake-default-tail-calls
branch
from
3a7f94d
to
afe0981
Compare
phated
changed the title
--experimental-wasm-tail-call with --no-wasm-tail-call; enable tail calls by default
ospencer
approved these changes
Mar 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ospencer
force-pushed
the
spotandjake-default-tail-calls
branch
from
afe0981
to
9a4aaf6
Compare
This was referenced Mar 11, 2023
This was referenced Mar 20, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
* feat: Make Tail Calls Default * fix: Disable Tail Calls In Near SmokeTest * Update size of smallest grain program --------- Co-authored-by: Oscar Spencer <oscar@grain-lang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr enables tail calls by default it adds the cli argument
--no-wasm-tail-calland removes the--experimental-wasm-tail-callscli argument.This is marked as a draft because in #1587 it is noted that there are some cases where tail calls currently leak which need to be fixed before this is default.
closes: #1587