Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Remove parseInt dependency on Pervasives #1649

Merged
merged 1 commit into from
Feb 1, 2023
Merged

feat(stdlib): Remove parseInt dependency on Pervasives #1649

merged 1 commit into from
Feb 1, 2023

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Feb 1, 2023

Closes #1050

@ospencer ospencer self-assigned this Feb 1, 2023
phated
phated approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fresh, so clean. Looks like you need to run the formatter though.

@ospencer ospencer merged commit 9408568 into main Feb 1, 2023
@ospencer ospencer deleted the oscar/parseint-pervasives branch February 1, 2023 21:20
@github-actions github-actions bot mentioned this pull request Feb 1, 2023
Merged
av8ta pushed a commit to av8ta/grain that referenced this pull request Apr 11, 2023
@ospencer
feat(stdlib): Remove parseInt dependency on Pervasives (grain-lang#1649)
ca95eff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stdlib: Remove parseInt dependency on Pervasives
2 participants
@ospencer @phated