feat(compiler)!: Allocate closures only when necessary #1660
Conversation
ospencer
requested review from
phated,
marcusroberts and
jozanza
as code owners
| assert ImmutablePriorityQueue.make(compare) == ImmutablePriorityQueue.empty | ||
|
|
There was a problem hiding this comment.
compare in one module is no longer necessarily equal to compare in another module because they can be different closures. There's no real equivalent of this test now. == currently just compares pointers for closures.
A test that checks something similar to this would be this: assert ImmutablePriorityQueue.isEmpty(ImmutablePriorityQueue.make(compare)), but I do not believe that was the essence of this test.
| @@ -81,7 +81,7 @@ describe("garbage collection", ({test, testSkip}) => { | |||
| ); | |||
| assertRunGCError( | |||
| "fib_gc_err", | |||
| 1024, | |||
| 512, | |||
There was a problem hiding this comment.
This no longer ran out of memory at 1024 bytes because no closure is allocated when fib is called anymore. I adjusted it down.
| ) | ||
| (local.get $0) | ||
| ) | ||
| (i32.const 0) |
There was a problem hiding this comment.
Is this now one of those tests where we are optimizing the whole thing away?
There was a problem hiding this comment.
The whole closure gets optimized away here (which shows that the feature is working!), but not the rest of the test.
ospencer
force-pushed
the
oscar/refactor-closures
branch
from
9f4c8d9
to
aa2e718
Compare
* feat(compiler)!: Allocate closures only when necessary * snapshots
Closes #1410
Works towards #1029
This PR only allocates closures when absolutely necessary—when a function actually closes over values or the function may be used in a first-class way.
This results in a 40% module size reduction for hello world programs, and similar 20-40% module size reductions for most Grain programs. It also improves program performance and module startup time.
This is breaking at the CMI level because consuming modules may need to allocate a closure for an imported function if it plans to use it in a first-class way.