feat(compiler): Allow importing a memory #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
requested review from
phated,
marcusroberts,
peblair and
jozanza
as code owners
ospencer
changed the title
peblair
approved these changes
Feb 11, 2023
phated
reviewed
Feb 12, 2023
|
@phated I mentioned in the description that no there isn't, but I remembered a way. |
|
Test added. |
phated
approved these changes
Feb 14, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
* feat: Allow importing a memory * add import_memory linking test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #1029
For compilers that support this functionality, they just support importing from
env.memory. We could make this a bit more complicated and allow passing the module name and memory name, but for now I don't think this is necessary.We don't currently have the ability to add a test for this because the memory import happens after linking.