feat(compiler)!: Custom box printing #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
jozanza and
phated
as code owners
ospencer
requested changes
Mar 1, 2023
I was wondering where I would put regression tests for these? |
ospencer
reviewed
Mar 1, 2023
|
You can add tests to compiler/test/suites/strings.re! |
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
ospencer
changed the title
|
I suppose this is technically breaking. |
ospencer
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Mar 4, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
* feat: Custom box Stringify * chore: Refactor Box Change * Update stdlib/runtime/string.gr Co-authored-by: Oscar Spencer <oscar.spen@gmail.com> * chore: Add Regression Tests --------- Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds custom box printing.
Now single argument tuples will be wrinted as
Box(1)intead of(1,)given the only safe way to create a single arugment tuple is by using the box primitive.I am wondering where I would add a regression test for this if needed I couldn't see anywhere, that we were testing
printortoString.Closes: #1620