feat(stdlib)!: Add optimization for Number.pow(Rational, Int)
#1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
peblair,
jozanza,
phated and
marcusroberts
as code owners
phated
changed the title
Rationional^IntRationional^Int
ospencer
reviewed
Mar 4, 2023
ospencer
changed the title
Rationional^IntNumber.pow(Rational, Int)
ospencer
approved these changes
Mar 4, 2023
This was referenced Mar 5, 2023
This was referenced Mar 20, 2023
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 11, 2023
…n-lang#1716) * feat!: Add Optimization for `Rationional^Int` * Update stdlib/runtime/numbers.gr --------- Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds an optimization for
Rational^int.Breaking because:
(1/2)^3no longer returns0.125but rather1/8.Furthur Discussed: #1706