feat(stdlib): Add toIntegerRatio and fromIntegerRatio to Rational Library
#1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
phated,
peblair,
marcusroberts and
jozanza
as code owners
spotandjake
changed the title
toIntegerRatio and fromIntegerRatio to Rational LibrarytoIntegerRatio and fromIntegerRatio to Rational Library
spotandjake
force-pushed
the
spotandjake-rational-funcs
branch
from
2a6e19f
to
f7c99ab
Compare
ospencer
reviewed
Mar 28, 2023
spotandjake
force-pushed
the
spotandjake-rational-funcs
branch
from
06ce1b2
to
d7d0e7f
Compare
ospencer
reviewed
Apr 8, 2023
spotandjake
force-pushed
the
spotandjake-rational-funcs
branch
from
380b5a9
to
36fd51a
Compare
Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
spotandjake
force-pushed
the
spotandjake-rational-funcs
branch
from
36fd51a
to
bfa8a45
Compare
av8ta
pushed a commit
to av8ta/grain
that referenced
this pull request
Apr 18, 2023
… Library (grain-lang#1746) * feat: Add `toIntegerRatio` and `fromIntegerRatio` to Rational Library * chore: Throw an exeception on `fromIntegerRation` * chore: run formatter * chore: Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Oscar Spencer <oscar.spen@gmail.com> * chore: Regen docs * chore: Apply suggestions from code review --------- Co-authored-by: Oscar Spencer <oscar.spen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
toIntegerRationandfromIntegerRation, to therationallibrary.This doesnt close #1672, but it adds a few of the functions for it.